[로또 게임] 권용현 과제 제출합니다. #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeonHee
requested changes
Jul 7, 2023
src/main/java/lotto/Game.java
Outdated
| Game(RandomNumber randomNumber, Input input, Print print) { | ||
| this.randomNumber = randomNumber; | ||
| this.input = input; | ||
| this.print = print; |
There was a problem hiding this comment.
외부에서 주입받은거는 좋은 시도입니다.
이걸 Interface로 추상화 시켜서 의존성을 낮추는 방식으로 리팩토링해보세요
src/main/java/lotto/Game.java
Outdated
| return list; | ||
| } | ||
|
|
||
| private void calculateWinCounts(int[] place, int idx, List<int[]> winCounts) { |
There was a problem hiding this comment.
프로그래밍에도 함수의 멱등성이라는 개념이 있는데요.
검색해서 찾아보고 멱등성을 만족하도록 함수를 리팩토링해보세요
KeonHee
requested changes
Jul 10, 2023
src/main/java/lotto/Application.java
Outdated
| public class Application { | ||
| public static void main(String[] args) { | ||
| // TODO: 프로그램 구현 | ||
| Game game = new GameImpl(RandomNumberImpl.getInstance(), InputImpl.getInstance(), PrintImpl.getInstance()); |
There was a problem hiding this comment.
잘했습니다 👍
이렇게 인터페이스화 시키면 테스트 코드 짜기가 편해질거에요
| if (randomNumber == null) { | ||
| randomNumber = new RandomNumberImpl(); | ||
| } | ||
| return randomNumber; |
There was a problem hiding this comment.
굳이 싱글톤으로 구현안해도되는 상황이긴한데 이왕했으니 제대로 구현해보면 좋을 것 같네요.
싱글톤에는 여러 구현방식이 있는데 보통 LazyHolder 방식으로 많이 구현하니까 검색해서 찾아보고 리팩토링해보세요~
There was a problem hiding this comment.
싱글톤 구현 방법들에 대해서 내일 이야기 해볼건데 한 번 공부해보세요 :) 지난 시간에 한번 언급했던 것 같네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변수명 짓는것이 아직 미숙한것 같습니다. 계속해서 리팩토링 해 나가도록 하겠습니다.