Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the density of the inverse Wishart distribution in the documentation #38

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

willemvandenboom
Copy link
Contributor

Changes to the documentation as suggested in #37

@singmann
Copy link
Contributor

Before I accept this, just one quick question: Did you check whether the implementation is actually correct and not wrong as in teh documentation?

@willemvandenboom
Copy link
Contributor Author

I had not yet checked, but I just did:
The implementations in dinvwishart and dinvwishartc are already in agreement with the formula of the inverse Wishart density in this pull request.

@singmann singmann merged commit de9107d into LaplacesDemonR:master Mar 27, 2024
@singmann
Copy link
Contributor

thanks, added.

Is there any chance you might be interested in addressing or adding pull requests for some of the other open issues? I have never actually used the package so cannot really judge whether these issues are correct.

@willemvandenboom willemvandenboom deleted the fix-doc-inv-wish branch March 28, 2024 00:47
@willemvandenboom
Copy link
Contributor Author

Thank you for merging and the invite to contribute further. However, I do not use the package much either, and currently do not have the time.

@singmann
Copy link
Contributor

No worries. Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants