Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI tests on PHP 8.4 and fix deprecations #5732

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

jnoordsij
Copy link
Contributor

WHY

BEFORE - What was wrong? What was happening before this PR?

Tests were not run on the latest PHP version (8.4; see https://www.php.net/releases/8.4/en.php).

AFTER - What is happening after this PR?

Tests are run and less deprecations are triggered.

HOW

How did you achieve that, in technical terms?

Is it a breaking change?

No

How can we test the before & after?

If the PR has changes in multiple repos please provide the command to checkout all branches, eg.:

git checkout "dev-branch-name" &&
cd vendor/backpack/crud && git checkout crud-branch-name &&
cd ../pro && git checkout pro-branch-name &&
cd ../../..

@pxpm
Copy link
Contributor

pxpm commented Dec 19, 2024

Thanks, @jnoordsij

I've tested this, and while doing so I also found a failing test in php 8.4.

I will merge this, and the fix after 👍

Cheers

@pxpm pxpm merged commit 4dd7e40 into Laravel-Backpack:main Dec 19, 2024
2 of 3 checks passed
@jnoordsij jnoordsij deleted the php8.4-support branch December 19, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants