Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Add image type enum and property in image_data #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lasley
Copy link
Member

@lasley lasley commented Sep 7, 2017

  • Add an enum for the image types. Currently mapped are the distinct values from an existing prod, with the one known value filled (prescription). Pending response from CP on others
  • Add image_type computed property in image_data that maps the type code using the enum

@lasley lasley added this to the 1.0 milestone Sep 7, 2017
@codecov
Copy link

codecov bot commented Sep 7, 2017

Codecov Report

Merging #40 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #40      +/-   ##
=========================================
+ Coverage   97.68%   97.7%   +0.01%     
=========================================
  Files          60      61       +1     
  Lines        1598    1610      +12     
  Branches       42      42              
=========================================
+ Hits         1561    1573      +12     
  Misses         20      20              
  Partials       17      17
Impacted Files Coverage Δ
carepoint/models/cph/image_data.py 100% <100%> (ø) ⬆️
carepoint/models/enum_image_type.py 100% <100%> (ø)

* Add an enum for the image types. Currently mapped are the distinct values from an existing prod, with the one known value filled (prescription). Pending response from CP on others
* Add `image_type` computed property in `image_data` that maps the type code using the enum
@lasley lasley force-pushed the feature/SMD-319-enum-image_type_cn branch from 8241e90 to 9f440a2 Compare September 7, 2017 19:56
@lasley
Copy link
Member Author

lasley commented Nov 10, 2017

To get the current list of these you can use the SQL below in the CPH database

select * from csct where ct_id = 420 (This will let you know that the CT_ID of 420 refers to image types.)

select * from csct_code where ct_id = 420 (The list of image types is defined in the csct_code table using the Code_num which you have below)

Example: Code of 2 in my database signifies an image listed as an RX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant