Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: move dashboard button to landing #122

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Feature: move dashboard button to landing #122

merged 4 commits into from
Mar 4, 2024

Conversation

teoh4770
Copy link
Contributor

@teoh4770 teoh4770 commented Mar 3, 2024

Issue: #120

Two things:

  1. Import the most impressive button component I have seen
  2. Update the existing button to button component that @juancwu created.

@teoh4770 teoh4770 added the enhancement New feature or request label Mar 3, 2024
@teoh4770 teoh4770 linked an issue Mar 3, 2024 that may be closed by this pull request
[Feature] Move Dashboard Button to Landing #120
Closed
@teoh4770
Copy link
Contributor Author

teoh4770 commented Mar 3, 2024

@juancwu any reason you setup this in tailwind.config if you don't use it?

'tbrand-mouse-down': '#1D7882',
'tbrand-highlight': '#00CEDB',

@teoh4770
Copy link
Contributor Author

teoh4770 commented Mar 4, 2024

Btw...it's not passing the automated check for some reason. Might need help on this one >:D

Warning: CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
Error: Path does not exist: eslint-results.sarif
ConfigurationError: Path does not exist: eslint-results.sarif
    at run (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:65:15)
    at async runWrapper (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:76:[9](https://github.com/LaurierHawkHacks/Landing/actions/runs/8127235652/job/22211846750?pr=122#step:5:10))

@juancwu
Copy link
Contributor

juancwu commented Mar 4, 2024

@juancwu any reason you setup this in tailwind.config if you don't use it?

'tbrand-mouse-down': '#1D7882',
'tbrand-highlight': '#00CEDB',

Did not make a whole lot sense when the colours are not widely shared so I just put in the arbitrary colours in the component. Left the styles cuz I forgot to remove them lol.

@juancwu
Copy link
Contributor

juancwu commented Mar 4, 2024

Btw...it's not passing the automated check for some reason. Might need help on this one >:D

Warning: CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
Error: Path does not exist: eslint-results.sarif
ConfigurationError: Path does not exist: eslint-results.sarif
    at run (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:65:15)
    at async runWrapper (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:76:[9](https://github.com/LaurierHawkHacks/Landing/actions/runs/8127235652/job/22211846750?pr=122#step:5:10))

I think its good to learn some DevOps @teoh4770 👀

@teoh4770
Copy link
Contributor Author

teoh4770 commented Mar 4, 2024

@juancwu any reason you setup this in tailwind.config if you don't use it?

'tbrand-mouse-down': '#1D7882',
'tbrand-highlight': '#00CEDB',

Did not make a whole lot sense when the colours are not widely shared so I just put in the arbitrary colours in the component. Left the styles cuz I forgot to remove them lol.

Solid reason lmao.

@teoh4770
Copy link
Contributor Author

teoh4770 commented Mar 4, 2024 •
edited
Loading

Btw...it's not passing the automated check for some reason. Might need help on this one >:D

Warning: CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
Error: Path does not exist: eslint-results.sarif
ConfigurationError: Path does not exist: eslint-results.sarif
    at run (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:65:15)
    at async runWrapper (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:76:[9](https://github.com/LaurierHawkHacks/Landing/actions/runs/8127235652/job/22211846750?pr=122#step:5:10))

I think its good to learn some DevOps @teoh4770 👀

Can't avoid DevOps 😭

juancwu added 3 commits March 3, 2024 23:14
@juancwu
remove export of type and button styles function
e6fbcf9 
optimize for optmize fash refresh by not exporting things other than components
and in this case exporting the getButtonStyles() and type ButtonStylesProps
are basically unnecessary
@juancwu
remove unsued eslint disable directive
aa80854
@juancwu
Merge branch 'main' into feature/120/move-dashboard-button-to-landing
8c7bc81
@juancwu
Copy link
Contributor

juancwu commented Mar 4, 2024

Btw...it's not passing the automated check for some reason. Might need help on this one >:D

Warning: CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
Error: Path does not exist: eslint-results.sarif
ConfigurationError: Path does not exist: eslint-results.sarif
    at run (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:65:15)
    at async runWrapper (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:76:[9](https://github.com/LaurierHawkHacks/Landing/actions/runs/8127235652/job/22211846750?pr=122#step:5:10))

I think its good to learn some DevOps @teoh4770 👀

Can't avoid DevOps 😭

Next time you can just run pnpm run lint to check for issues when its the eslint action.

I have updated the PR with the changes needed.

@teoh4770
Copy link
Contributor Author

teoh4770 commented Mar 4, 2024

Btw...it's not passing the automated check for some reason. Might need help on this one >:D

Warning: CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
Error: Path does not exist: eslint-results.sarif
ConfigurationError: Path does not exist: eslint-results.sarif
    at run (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:65:15)
    at async runWrapper (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:76:[9](https://github.com/LaurierHawkHacks/Landing/actions/runs/8127235652/job/22211846750?pr=122#step:5:10))

I think its good to learn some DevOps @teoh4770 👀

Can't avoid DevOps 😭

Next time you can just run pnpm run lint to check for issues when its the eslint action.

I have updated the PR with the changes needed.

Noted

@juancwu juancwu merged commit 301da6e into main Mar 4, 2024
3 checks passed
@juancwu
Copy link
Contributor

juancwu commented Mar 4, 2024

Merge so that new branches can use the button component.

@juancwu juancwu deleted the feature/120/move-dashboard-button-to-landing branch March 4, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancwu juancwu juancwu approved these changes

@AmirAgassi AmirAgassi Awaiting requested review from AmirAgassi

@aidantrabs aidantrabs Awaiting requested review from aidantrabs aidantrabs is a code owner

@ABCodez ABCodez Awaiting requested review from ABCodez

Assignees

@juancwu juancwu

@teoh4770 teoh4770

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Move Dashboard Button to Landing
2 participants
@teoh4770 @juancwu