feature/96/faq #123
Merged
feature/96/faq #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
norachams
commented
Mar 3, 2024
norachams
commented
GabeDiniz
requested changes
Mar 3, 2024
|
Are the comments marked as resolved because they are being worked on @norachams ? If yes, a comment saying they are being worked on would be nice if changes have not been committed. |
juancwu
reviewed
Mar 4, 2024
| onClick={() => toggleAccordion(index)} | ||
| > | ||
| <h6 className="text-black">{item.question}</h6> | ||
| <span>{activeIndex === index ? '^' : '⌄'}</span> |
There was a problem hiding this comment.
I think using an proper icon would make it look better. There is a slight change in position and size when active.
I recommend using:
A list of available icons:
There was a problem hiding this comment.
@norachams Just making sure this doesn't get forgotten.
juancwu
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.