Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: improve hero section #159

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Fix: improve hero section #159

merged 6 commits into from
Mar 27, 2024

Conversation

teoh4770
Copy link
Contributor

@teoh4770 teoh4770 commented Mar 27, 2024

Issue: #153
Branch: fix/153/improve-hero-section

  • Remove the redundant logo in hero section
  • Remove the text on the platform in mobile view (since it is blurry)
  • Improve the text proportion of hero section

Note: The commit is inconsistent, will try to improve next time

@teoh4770 teoh4770 added the bug Something isn't working label Mar 27, 2024
@teoh4770 teoh4770 self-assigned this Mar 27, 2024
@teoh4770 teoh4770 linked an issue Mar 27, 2024 that may be closed by this pull request
3 tasks
@teoh4770 teoh4770 changed the title fix: remove the redundant logo in hero section Fix: improve hero sectoin Mar 27, 2024
@teoh4770 teoh4770 changed the title Fix: improve hero sectoin Fix: improve hero section Mar 27, 2024
Copy link
Contributor

@GabeDiniz GabeDiniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, it LGTM. Seems like the design team is happy with it too in the Discord chat.! 👏🏽

<h1 className="bg-gradient-to-b from-[#2B6469] to-[#00CEDB] bg-clip-text text-4xl font-extrabold text-transparent sm:text-5.5xl lg:text-7xl xl:text-8.5xl">
<div className="mx-auto mt-16 px-4 sm:ml-16 sm:mt-16 sm:px-0 lg:ml-20 lg:mt-24 xl:ml-24 xl:mt-32 2xl:mt-10">
<div>
{/* lg:w-36 */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you meant to keep it, but remove this comment if its no longer needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted :)

@teoh4770 teoh4770 added style and removed style labels Mar 27, 2024
@aidantrabs aidantrabs merged commit 4964080 into main Mar 27, 2024
3 checks passed
@aidantrabs aidantrabs deleted the fix/153/improve-hero-section branch June 3, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] Improve Hero Section
3 participants