Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/265/Redo-FAQ-section-with-new-styling #266

Merged
merged 14 commits into from
Apr 23, 2024

Conversation

ABCodez
Copy link
Contributor

@ABCodez ABCodez commented Apr 7, 2024

image
image

@ABCodez ABCodez self-assigned this Apr 7, 2024
@teoh4770
Copy link
Contributor

teoh4770 commented Apr 9, 2024

@ABCodez

  1. I believe the tabs buttons can be smaller in the mobile view, so that they are not taking too much space
  2. also, try to make the accordion item text left align, somehow when the text break into another line, the text shift as well
  3. can you try to remove the accordion card expand transition, it is the main reason why it felt janky
  4. the faq in mobile looks kinda huge tbh

@ABCodez
Copy link
Contributor Author

ABCodez commented Apr 9, 2024

@teoh4770, I made a few changes based on ur feedback ! Everything should look a bit more cleaned up + smaller on mobile. The categories section still looks a bit big on mobile, the original design had it be an accordion as well but, I feel like that'd just be too much lol.

Check it out tho, and lmk what ya think :)

@teoh4770
Copy link
Contributor

teoh4770 commented Apr 9, 2024

@ABCodez is better now for sure, but the tabs section is almost the same size as the content itself. You can improve the tab section in mobile view, by making it smaller(than the accordion) and draw less attention. Keep the ratio between the tabs and the accordion in mobile view the same the desktop view.

Screenshot 2024-04-09 at 7 59 06 AM

Screenshot 2024-04-09 at 7 59 22 AM

@ABCodez
Copy link
Contributor Author

ABCodez commented Apr 15, 2024

New styling for FAQ

image image

@ABCodez ABCodez requested a review from teoh4770 April 15, 2024 01:21
@teoh4770
Copy link
Contributor

Way better than the OG one. But personally thought that the heading size is slightly bigger? You can refer to the other section's header to see if the size is aligned.

@aidantrabs aidantrabs merged commit cecd948 into main Apr 23, 2024
3 checks passed
@aidantrabs aidantrabs deleted the fix/Update-FAQ-section branch June 3, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants