Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: center about section on mobile #271

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: center about section on mobile #271

merged 1 commit into from
Apr 8, 2024

Conversation

teoh4770
Copy link
Contributor

@teoh4770 teoh4770 commented Apr 8, 2024

Issue: #270
Branch: fix/270/about-section-text-not-centered

🔍 What's Included
The issue may due to merging issue again.

  1. I only need to decrease the spacing below the heading in about section in mobile.
  2. Adding key to the sponsor list to remove the warning

📁 Files Affected:
src/components/sections/HeroStats.section.tsx
src/components/sections/Sponsor.section.tsx

@teoh4770 teoh4770 added the style label Apr 8, 2024
@teoh4770 teoh4770 self-assigned this Apr 8, 2024
@teoh4770 teoh4770 linked an issue Apr 8, 2024 that may be closed by this pull request
[Fix] About section text not centered on mobile #270
Closed
@teoh4770 teoh4770 requested review from AmirAgassi and GabeDiniz April 8, 2024 04:22
GabeDiniz
GabeDiniz approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@GabeDiniz GabeDiniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch with the warning Chee! ✅

@aidantrabs aidantrabs merged commit 7faedb2 into main Apr 8, 2024
3 checks passed
@aidantrabs aidantrabs deleted the fix/270/about-section-text-not-centered branch June 3, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabeDiniz GabeDiniz GabeDiniz approved these changes

@juancwu juancwu Awaiting requested review from juancwu juancwu is a code owner

@aidantrabs aidantrabs Awaiting requested review from aidantrabs aidantrabs is a code owner

@SherRao SherRao Awaiting requested review from SherRao SherRao is a code owner

@AmirAgassi AmirAgassi Awaiting requested review from AmirAgassi

Assignees

@teoh4770 teoh4770

Labels
style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] About section text not centered on mobile
3 participants
@teoh4770 @GabeDiniz @aidantrabs