Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set custom DateTime format for smartspace #4500

Draft
wants to merge 3 commits into
base: 15-dev
Choose a base branch
from
Draft

Set custom DateTime format for smartspace #4500

wants to merge 3 commits into from
+111 −4

Conversation

validcube
Copy link
Contributor

@validcube validcube commented Jun 23, 2024 •
edited
Loading

🔥 Highly Experimental

Caution

This PR is highly experimental, there are lots of known bugs and unfinished features which are listed below:

  • When the user applies an incompatible Java DateTime format, Lawnchair will crash.
  • There should be an indicator when falling back to the Gregorian calendar due to an incompatible format.
  • There should be a DateTime preview inside the TextPreference's description.
  • Layout doesn't really make sense
  • Rough implementation should be polished (Does Custom value for Time needed when we can set Custom Date?)
  • Lock this behind experimental settings (?)

Description

Fixes

Fixes Issues (populated as of June 23rd 2024)

Type of change

❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
✅ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)

@validcube
Add custom date and time format for Smartspace
a4d2e5c 
Adds the ability for users to customize the date and time format displayed in Smartspace.
@validcube
🔮 Merge repository updated to latest snapshot!
8a997ae 
Script Execution UTC Time: null

Signed-off-by: validcube <[email protected]>
@validcube validcube changed the title Smartspace bizzare adventure Set custom DateTime format for smartspace Jun 23, 2024
@validcube
🔮 Merge repository updated to latest snapshot!
25f47a7 
Script Execution UTC Time: null
@validcube validcube mentioned this pull request Sep 21, 2024
Closed
@validcube validcube changed the base branch from 14-dev to 15-dev November 3, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Custom Time/Date formats for Lawnchair's At a Glance
1 participant
@validcube