Avoid ResourceWarning if shutdown failed for some reason #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following warning appears transiently from time to time while working with websockets:
Investigation shows that this warning appears if
self.sock.shutdown(socket.SHUT_RDWR)
(line 225) throws exception and thusself.sock.close()
(line 226) is not called and execution proceeds straight toself.sock = None
(line 230), and that produces theResourceWarning
mentioned above.The exception itself is hidden by
pass
statement (line 228), but additional investigation showed the following example of that exception:The reliable reproduction of this situation is problematic, but I've created the following test that reproduces the problem reliably and should pass if the problem is fixed:
Here's the output: