feat: Add reconnect method

LayerZero-Labs · Nov 25, 2023 · 089ac67 · 089ac67
1 parent cee5dde
commit 089ac67
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 1 deletion.
diff --git a/packages/ua-utils/src/omnigraph/builder.ts b/packages/ua-utils/src/omnigraph/builder.ts
@@ -66,8 +66,8 @@ export class OmniGraphBuilder<TNodeConfig, TEdgeConfig> {
                     const existingEdge = this.getEdgeAt({ from: fromNode.point, to: toNode.point })
                     const newEdge = r(fromNode, toNode, existingEdge)
 
+                    if (existingEdge != null) this.removeEdgeAt(existingEdge.vector)
                     if (newEdge != null) this.addEdges(newEdge)
-                    else if (existingEdge != null) this.removeEdgeAt(existingEdge.vector)
                 })
             ),
             this

diff --git a/packages/ua-utils/test/omnigraph/builder.test.ts b/packages/ua-utils/test/omnigraph/builder.test.ts
@@ -294,6 +294,45 @@ describe('omnigraph/builder', () => {
                 )
             })
         })
+
+        describe('reconnect', () => {
+            it('should return self', () => {
+                const builder = new OmniGraphBuilder()
+                const reconnector = jest.fn()
+
+                expect(builder.reconnect(reconnector)).toBe(builder)
+            })
+
+            it('should not call reconnector when there are no nodes', () => {
+                const builder = new OmniGraphBuilder()
+                const reconnector = jest.fn()
+
+                builder.reconnect(reconnector)
+
+                expect(builder.nodes).toEqual([])
+                expect(builder.edges).toEqual([])
+                expect(reconnector).not.toHaveBeenCalled()
+            })
+
+            it('should call reconnector for every node combination', () => {
+                fc.assert(
+                    fc.property(nodesArbitrary, (nodes) => {
+                        const builder = new OmniGraphBuilder()
+                        const reconnector = jest.fn()
+
+                        builder.addNodes(...nodes)
+                        builder.reconnect(reconnector)
+                        expect(reconnector).toHaveBeenCalledTimes(builder.nodes.length * builder.nodes.length)
+
+                        for (const nodeA of builder.nodes) {
+                            for (const nodeB of builder.nodes) {
+                                expect(reconnector).toHaveBeenCalledWith(nodeA, nodeB, undefined)
+                            }
+                        }
+                    })
+                )
+            })
+        })
     })
 
     describe('accessor methods', () => {