Skip to content

Commit

Permalink
chore: follow up PR feedback from Jan surrounding constructor args
Browse files Browse the repository at this point in the history
Signed-off-by: Ryan Goulding <[email protected]>
  • Loading branch information
ryandgoulding committed Feb 16, 2024
1 parent 98f4a8b commit ce99480
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions packages/devtools-evm/src/signer/sdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,7 @@ export abstract class OmniSignerEVMBase implements OmniSigner {
* Implements an OmniSigner interface for EVM-compatible chains
*/
export class OmniSignerEVM extends OmniSignerEVMBase {
constructor(
public override readonly eid: EndpointId,
public override readonly signer: Signer
) {
constructor(eid: EndpointId, signer: Signer) {
super(eid, signer)
}

Expand Down Expand Up @@ -88,8 +85,8 @@ export class GnosisOmniSignerEVM<TSafeConfig extends ConnectSafeConfig> extends
protected safeService: SafeServiceClient | undefined

constructor(
public override readonly eid: EndpointId,
public override readonly signer: Signer,
eid: EndpointId,
signer: Signer,
protected readonly safeUrl: string,
protected readonly safeConfig: TSafeConfig
) {
Expand Down

0 comments on commit ce99480

Please sign in to comment.