🚧 Segmentation fault in jest/mocha #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjakubnanista
requested review from
ryandgoulding,
TRileySchwarz,
0xIryna and
sirarthurmoney
ryandgoulding
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
There is a nasty problem with test runners - using dynamic
importinside of a test run triggers a segmentation fault. This prevented a lot of good stuff from happening, namely having a way more sophisticated output in the console (the required modules are ESM and require us to load them usingawait import().The error has been reported many times and fixed in node itself after causing many headaches in tests
The solution consists of two things - updating the base node image and not caching
jesttest runs (jest cache is slow anyways).To add a feature to a bugfix I made the base node version controllable using
NODE_VERSIONbuild argument so we can test with any compatible node versions if we want (matrix tests will possibly soon be necessary).(I also dropped an unused YAML template)