New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪚 Return pending transactions from signAndSend #175

Merged

janjakubnanista merged 3 commits into main from signer-factory-pending

Jan 9, 2024

Contributor

janjakubnanista commented Jan 9, 2024 •

edited

Loading

In this PR

Return all the transactions that have not been submitted (including any failed ones) when signing and sending. This is useful for the next step, task-level retry logic
Adjust the return type - return an OmniTransactionWithError instead of OmniError for easy linking with a transaction

janjakubnanista added 3 commits

January 9, 2024 15:46


          chore: Return pending transactions from createSignAndSend()

5f303ed


          chore: Some docs

ad8b0bd


          chore: Changeset

adcb027

janjakubnanista requested review from ryandgoulding and sirarthurmoney

January 9, 2024 23:50

ryandgoulding approved these changes

View reviewed changes

janjakubnanista merged commit 2dac0da into main

2 checks passed

janjakubnanista deleted the signer-factory-pending branch

January 9, 2024 23:58

sirarthurmoney pushed a commit that referenced this pull request


          🪚 Return pending transactions from signAndSend (#175)

d0045f2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet