-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪚 Adding E2E test infrastructure #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjakubnanista
force-pushed
the
ua-utils-structure-003
branch
from
November 17, 2023 00:29
1bab34d
to
67cd9a9
Compare
janjakubnanista
requested review from
TRileySchwarz,
0xIryna and
sirarthurmoney
November 17, 2023 00:40
0xIryna
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Adding container-based E2E testing infrastructure. This consists of:
Dockerfile
that can build this project. If we were not usingyarn
everywhere I would definitely suggestpnpm
because yarn is not capable of installing dependencies based on just theyarn.lock
file. This means the whole codebase needs to be copied to the image beforeyarn install
is ran which in turn means that there is no caching ofyarn install
. Pathetic.docker-compose.templates.yaml
files that define reusable services. The idea here is to write as little code as possible because who likes code I don't so we'll reuse everything we candocker-compose.yaml
files for the actual setupsHow does it all work together? you might ask, knowing you already.
hardhat node
processes - seepackages/ua-utils-test-v2/docker-compose.yaml
EndpointV2
to them. This is done using an ordinaryhardhat deploy
script which we'll need to expand with the endpoint configuration - seeservices/bootstrap
inpackages/ua-utils-test-v2/dcoker-compose.yaml
services/test
inpackages/ua-utils-test-v2/dcoker-compose.yaml