Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Fix lz:deploy task not being able to find external deployments #372

Merged
merged 13 commits into from
Feb 8, 2024

Conversation

janjakubnanista
Copy link
Contributor

In this PR

  • The run function on DeploymentsExtension would clear its database if resetMemory wasn't explicitly set to false. This also cleared the external deployments and made EndpointV2 deployment not accessible in the deploy script.
  • The fix is very tricky to test so I introduced two user tests that basically check that nox hardhat lz:deploy will not fail on a missing deployment. First I made these tests fail (see here) and then introduced a fix. The trickiness of this test is the fact that we'd need to completely erase the runtime between every test - something we might still want to do. In the meantime I covered the task with basic tests and made sure that from the users' perspective the deploy task works [*]
  • Added a small fix - The --ci should be a CLI flag, not a parameter that takes a boolean value

[*] Well what we do is we test that the deploy task fails, but it fails on insufficient funds. It might be nice to add a nightly test that uses a funded testnet mnemonic / private key to actually run all the deployment and wiring

@janjakubnanista janjakubnanista merged commit 5675416 into main Feb 8, 2024
5 checks passed
@janjakubnanista janjakubnanista deleted the deployment-fixes branch February 8, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants