🪲 Fix lz:deploy task not being able to find external deployments #372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
run
function onDeploymentsExtension
would clear its database ifresetMemory
wasn't explicitly set tofalse
. This also cleared the external deployments and madeEndpointV2
deployment not accessible in the deploy script.nox hardhat lz:deploy
will not fail on a missing deployment. First I made these tests fail (see here) and then introduced a fix. The trickiness of this test is the fact that we'd need to completely erase the runtime between every test - something we might still want to do. In the meantime I covered the task with basic tests and made sure that from the users' perspective the deploy task works [*]--ci
should be a CLI flag, not a parameter that takes a boolean value[*] Well what we do is we test that the deploy task fails, but it fails on insufficient funds. It might be nice to add a nightly test that uses a funded testnet mnemonic / private key to actually run all the deployment and wiring