Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗞️ Investigate migration to Ethers v6 #385

Closed
wants to merge 21 commits into from
Closed

Conversation

janjakubnanista
Copy link
Contributor

@janjakubnanista janjakubnanista commented Feb 10, 2024

In this PR

  • See if we can migrate to ethers@6 without any major issues (unlikely - the last time we tried we ran into transitive dependency issues with zksync-web3 we are now blocked on our own packages - lz-v2-utilities depends on [email protected] and imports directly from ethers/lib/utils)

Copy link

socket-security bot commented Feb 10, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: network +7 19.6 MB ricmoo

🚮 Removed packages: npm/[email protected]

View full report↗︎

@janjakubnanista janjakubnanista force-pushed the ethers-6 branch 2 times, most recently from 6bc3312 to c7bc6aa Compare February 14, 2024 18:01
@janjakubnanista janjakubnanista added do not merge chore Code improvement that does not modify the feature set labels Feb 28, 2024
@janjakubnanista
Copy link
Contributor Author

We might want to revisit this later or just switch to viem, closing for now

@janjakubnanista janjakubnanista deleted the ethers-6 branch June 4, 2024 16:40
@Berbex
Copy link

Berbex commented Jul 12, 2024

Why the branch was deleted? Is not in the roadmap continue with the bump of ethers version? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Code improvement that does not modify the feature set do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants