Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪚 OmniGraph™ Signing a transaction #51

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

janjakubnanista
Copy link
Contributor

In this PR

  • Moving the most generic types to a utils package. This name seems a bit generic but it follows the naming convention
  • Moving some of the arbitraries to test-utils. it would be nice to have them typed but that would create a dependency cycle - if test-utils depend on the types from utils and we want to use test-utils to test utils, we in trouble. However, this being a testing package, we don't care
  • Creating the first draft of OmniSigner interface and an EVM implementation
  • Use this signer implementation to enlarge the testing suite - new test has been added for configureOApp that now checks whether the function ignores the peers that have already been set

@janjakubnanista janjakubnanista merged commit 1704d5f into main Dec 1, 2023
@janjakubnanista janjakubnanista deleted the ominchain-config--007--utils branch December 1, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants