Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪚 OmniGraph™ Better docker setup #56

Merged
merged 8 commits into from
Dec 4, 2023

Conversation

janjakubnanista
Copy link
Contributor

@janjakubnanista janjakubnanista commented Dec 4, 2023

In this PR

Navigating @sirarthurmoney through the testing setup, I realized the current setup had several shortcomings:

  • Needing to rebuild the containers when a code change has been made. This was annoying when adding functionality to e.g. ua-utils-evm-hardhat and testing it using ua-utils-evm-hardhat-test. In this case, new containers needed to be built, which was not immediately obvious
  • The containers were not taking advantage of turbo cache since they were all isolated

As a remedy the following has changed:

  • Dockerfile now builds the whole project without the need to specify the PACKAGE. This is better suited to our use case where we are not deploying any services so our images can contain the whole project
  • bootstrap container has been replaced with pretest script
  • The hardhat EVM node now has its minimal package. This one is fast to build so the startup is faster. The only thing to keep in mind is that the MNEMONIC needs to be synced with the test setups so that the accounts are funded
  • The turbo cache is now being used in CI

The overall usability improvements are accompanied by reduction of CI runtime to ~6 minutes

@janjakubnanista janjakubnanista merged commit 3f431da into main Dec 4, 2023
@janjakubnanista janjakubnanista deleted the ominchain-config--010--dockers branch December 4, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants