Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪚 OmniGraph™ Stub of OApp wire task #83

Merged
merged 3 commits into from
Dec 9, 2023
Merged

🪚 OmniGraph™ Stub of OApp wire task #83

merged 3 commits into from
Dec 9, 2023

Conversation

janjakubnanista
Copy link
Contributor

In this PR

  • Adding a stub of OApp wire task called lz:oapp:wire. This task for now only validates the config and asks the user to continue. If the user continues, the task does nothing as opposed to when they don't continue in which case it does nothing, but faster
  • The task now contains code that needs to be moved outside to be reused in other tasks - the config loading will be used over and over again as well as the error formatting

0xIryna
0xIryna approved these changes Dec 9, 2023
View reviewed changes
Copy link

@0xIryna 0xIryna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦔🦔

sirarthurmoney

This comment was marked as duplicate.

Sign in to view

sirarthurmoney
sirarthurmoney approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@sirarthurmoney sirarthurmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦆

@janjakubnanista janjakubnanista merged commit 63231ac into main Dec 9, 2023
@janjakubnanista janjakubnanista deleted the ominchain-config--015--wire-all branch December 9, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xIryna 0xIryna 0xIryna approved these changes

@sirarthurmoney sirarthurmoney sirarthurmoney approved these changes

@ryandgoulding ryandgoulding Awaiting requested review from ryandgoulding

@TRileySchwarz TRileySchwarz Awaiting requested review from TRileySchwarz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janjakubnanista @0xIryna @sirarthurmoney