Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪚 OmniGraph™ Base SDKs - classes and interfaces #96

Merged
merged 3 commits into from
Dec 11, 2023
Merged

🪚 OmniGraph™ Base SDKs - classes and interfaces #96

merged 3 commits into from
Dec 11, 2023

Conversation

janjakubnanista
Copy link
Contributor

@janjakubnanista janjakubnanista commented Dec 11, 2023 •
edited
Loading

In this PR

  • Create IOmniSDK as a base interface for all SDKs (abstract & EVM versions)
  • Create a base class for all EVM SDKs
  • Add tuple labels & change string to Address in IEndpoint & Endpoint

As a nice to have improvement, we should decide whether to go for the I prefix everywhere (e.g. OmniPoint → IOmniPoint)

sirarthurmoney
sirarthurmoney approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@sirarthurmoney sirarthurmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎅

@janjakubnanista janjakubnanista merged commit 5fd7196 into main Dec 11, 2023
1 check passed
@janjakubnanista janjakubnanista deleted the ominchain-config--019--sdks branch December 11, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirarthurmoney sirarthurmoney sirarthurmoney approved these changes

@ryandgoulding ryandgoulding Awaiting requested review from ryandgoulding

@TRileySchwarz TRileySchwarz Awaiting requested review from TRileySchwarz

@0xIryna 0xIryna Awaiting requested review from 0xIryna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janjakubnanista @sirarthurmoney