Add "encoding" option #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @tpimh thanks for adding this, it looks like a helpful option. It will be merged and included in the next release. Can you add the option in the readme as well please? Maybe others would need this option too, and is easier to see it there. Thanks |
|
Sure, I will be happy to add the option to readme and write a test for the server that I am using it with. |
|
@tpimh the encoding option is set only for |
|
Yes, that's correct. That is something I have noticed when writing documentation, so I will be changing this and updating this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How I use it is, if the response can contain special characters in an 8 bit encoding, I set "encoding" to "binary". This is similar to how node-whois module does it. It can be considered a new feature, but I don't think it's significant enough.