Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate second round of feedback from lightblocks #12

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

samlaf
Copy link
Contributor

@samlaf samlaf commented Feb 13, 2024

lightblocks shared this feedback with us:

  • BLS apk registry is assumed to exist on the registry coordinator, if it does not exist then the error displayed does not describe that the BLS apk registry is missing
  • Quorum numbers displaying “AA==” instead of [0] for us
  • After “Transaction not yet mined” tx hash, another tx hash is printed however the “not yet mined” hash is the one executed

This PR fixes all 3. Only quorums is fixed here. The other 2 were bugs in sdk, which I am waiting for those PRs to be reviewed and merge before updating the sdk version in this PR to get those changes in: have been merged

@samlaf samlaf marked this pull request as draft February 13, 2024 05:38
@samlaf samlaf marked this pull request as ready for review February 14, 2024 23:10
@samlaf samlaf requested review from ian-shim and dmanc February 14, 2024 23:10
@samlaf samlaf merged commit ec0212b into master Feb 15, 2024
1 check passed
@samlaf samlaf deleted the incorporate-more-lightblocks-feedback branch February 15, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants