feat: public s3 config option (#277)

Layr-Labs · Feb 5, 2025 · 18e5a85 · 18e5a85
1 parent 8b77af9
commit 18e5a85
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -285,7 +285,7 @@ To quickly set up monitoring dashboard, add eigenda-proxy metrics endpoint to a
 | `--metrics.enabled`                         | `false`                         | `$EIGENDA_PROXY_METRICS_ENABLED`                         | Enable the metrics server.                                                                                                                                                                                    |
 | `--metrics.port`                            | `7300`                          | `$EIGENDA_PROXY_METRICS_PORT`                            | Metrics listening port.                                                                                                                                                                                       |
 | `--port`                                    | `3100`                          | `$EIGENDA_PROXY_PORT`                                    | Server listening port.                                                                                                                                                                                        |
-| `--s3.credential-type`                      |                                 | `$EIGENDA_PROXY_S3_CREDENTIAL_TYPE`                      | Static or iam.                                                                                                                                                                                                |
+| `--s3.credential-type`                      |                                 | `$EIGENDA_PROXY_S3_CREDENTIAL_TYPE`                      | Static, iam or public.                                                                                                                                                                                                |
 | `--s3.access-key-id`                        |                                 | `$EIGENDA_PROXY_S3_ACCESS_KEY_ID`                        | Access key id for S3 storage.                                                                                                                                                                                 |
 | `--s3.access-key-id`                        |                                 | `$EIGENDA_PROXY_S3_ACCESS_KEY_ID`                        | Access key id for S3 storage.                                                                                                                                                                                 |
 | `--s3.access-key-secret`                    |                                 | `$EIGENDA_PROXY_S3_ACCESS_KEY_SECRET`                    | Access key secret for S3 storage.                                                                                                                                                                             |

diff --git a/store/precomputed_key/s3/cli.go b/store/precomputed_key/s3/cli.go
@@ -42,7 +42,7 @@ func CLIFlags(envPrefix, category string) []cli.Flag {
 		},
 		&cli.StringFlag{
 			Name:     CredentialTypeFlagName,
-			Usage:    "the way to authenticate to S3, options are [iam, static]",
+			Usage:    "the way to authenticate to S3, options are [iam, static, public]",
 			EnvVars:  withEnvPrefix(envPrefix, "CREDENTIAL_TYPE"),
 			Category: category,
 		},

diff --git a/store/precomputed_key/s3/s3.go b/store/precomputed_key/s3/s3.go
@@ -21,6 +21,7 @@ import (
 const (
 	CredentialTypeStatic  CredentialType = "static"
 	CredentialTypeIAM     CredentialType = "iam"
+	CredentialTypePublic  CredentialType = "public"
 	CredentialTypeUnknown CredentialType = "unknown"
 )
 
@@ -30,6 +31,8 @@ func StringToCredentialType(s string) CredentialType {
 		return CredentialTypeStatic
 	case "iam":
 		return CredentialTypeIAM
+	case "public":
+		return CredentialTypePublic
 	default:
 		return CredentialTypeUnknown
 	}
@@ -138,5 +141,8 @@ func creds(cfg Config) *credentials.Credentials {
 	if cfg.CredentialType == CredentialTypeIAM {
 		return credentials.NewIAM("")
 	}
+	if cfg.CredentialType == CredentialTypePublic {
+		return nil
+	}
 	return credentials.NewStaticV4(cfg.AccessKeyID, cfg.AccessKeySecret, "")
 }