Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Optimism dependency to OP-Stack 1.9.2 #150

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

karlb
Copy link
Contributor

@karlb karlb commented Sep 24, 2024

Updates:

  • optimism v1.9.0 -> v1.9.2
  • op-geth to the commit 110c433a2469 which is used by optimism v1.9.2
  • removed unnecessary version replacements * go-kzg-4844 now uses v1.0.0 * pebble now uses v1.1.2

Necessary code changes:

  • opio is now ctxinterrupt
  • plasma is now alt-da

@karlb karlb marked this pull request as ready for review September 24, 2024 15:02
@karlb
Copy link
Contributor Author

karlb commented Sep 24, 2024

Is the holesky-test supposed to work for me in CI? I only see the SIGNER_PRIVATE_KEY environment variable not set error and don't think I caused that by the changes in this PR.

@samlaf
Copy link
Collaborator

samlaf commented Sep 26, 2024

@karlb just merged #153 which should allow your PR to read the secret key. Tried changing the target branch but it seems like the workflow is still running in the context of your PR's outdated workflow. Can you try rebasing on top of main to get access to new workflow?

@karlb karlb force-pushed the karlb/update-to-op-stack-1.9.2 branch from 81b91b1 to 0ef3ba7 Compare September 27, 2024 14:29
Updates:
* optimism v1.9.0 -> v1.9.2
* op-geth to the commit 110c433a2469 which is used by optimism v1.9.2
* removed unnecessary version replacements
    * go-kzg-4844 now uses v1.0.0
    * pebble now uses v1.1.2

Necessary code changes:
* opio is now ctxinterrupt
* plasma is now alt-da
@karlb karlb force-pushed the karlb/update-to-op-stack-1.9.2 branch from 0ef3ba7 to 384b85d Compare September 27, 2024 14:38
@karlb
Copy link
Contributor Author

karlb commented Sep 27, 2024

@samlaf I did the rebase and the holesky-test now succeeds. The other tests need approval to run in CI, but I don't think I've broken them during the rebase, so they should also pass.

Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @karlb !!

@samlaf samlaf merged commit d4ef8c5 into Layr-Labs:main Sep 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants