fix: verifier srs flags paths #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxue-l2
reviewed
Sep 29, 2024
| // in case we move this file around | ||
| Value: "../resources/g1.point", | ||
| // we use a relative path so that the path works for both the binary and the docker container | ||
| // aka we assume the binary is run from root dir, and that the resources/ dir is copied into the working dir of the container |
There was a problem hiding this comment.
I thought binary is run from the workdir, which is /app
There was a problem hiding this comment.
That’s the binary in the container. By binary here I just meant if we make + .//bin/… or go run
bxue-l2
approved these changes
Sep 29, 2024
bxue-l2
reviewed
Sep 29, 2024
| Category: category, | ||
| }, | ||
| &cli.StringFlag{ | ||
| Name: CachePathFlagName, | ||
| Usage: "Directory path to SRS tables for caching.", | ||
| EnvVars: withEnvPrefix(envPrefix, "TARGET_CACHE_PATH"), | ||
| Value: "../resources/SRSTables/", | ||
| // we use a relative path so that the path works for both the binary and the docker container | ||
| // aka we assume the binary is run from root dir, and that the resources/ dir is copied into the working dir of the container |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a mistake in #146
paths should have remained the same given that they are relative to where the binary is run from, not where the go file lives. Fixed and added a comment to that effect.