Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug in delegation approval when no signer provided #235

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: bug in delegation approval when no signer provided #235

merged 1 commit into from
Oct 29, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

Fixes # .

What Changed?

  • When no signer is provided, the command fails. But we want to generate salt for the approver to sign by themselves. This fixes it.

@shrimalmadhur shrimalmadhur merged commit 5653e62 into master Oct 29, 2024
8 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/fix-without-priv-key-delegation branch October 29, 2024 01:49
bdchatham pushed a commit to bdchatham/eigenlayer-cli that referenced this pull request Nov 13, 2024
@shrimalmadhur
fix: bug in delegation approval when no signer provided (Layr-Labs#235)
9272e6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdchatham bdchatham bdchatham approved these changes

@gpabst gpabst Awaiting requested review from gpabst

@nelsonijih nelsonijih Awaiting requested review from nelsonijih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @bdchatham