fix: delegate shares #1045
Open
fix: delegate shares #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
8sunyuan
reviewed
Jan 28, 2025
8sunyuan
reviewed
Jan 28, 2025
wadealexc
reviewed
Jan 30, 2025
ypatil12
reviewed
Jan 31, 2025
wadealexc
reviewed
Jan 31, 2025
wadealexc
reviewed
Feb 3, 2025
eigenmikem
force-pushed
the
delegate-shares-fix
branch
from
7c51aa4 to
9757137
Compare
ypatil12
reviewed
Feb 3, 2025
wadealexc
reviewed
Feb 4, 2025
wadealexc
reviewed
Feb 4, 2025
wadealexc
reviewed
Feb 5, 2025
Comment on lines
497
to
499
| if (depositSharesToWithdraw[i] == sharesAfter) { | ||
| _depositScalingFactor[staker][strategies[i]].reset(); | ||
| } |
There was a problem hiding this comment.
Is this right? I thought it should be sharesAfter == 0?
There was a problem hiding this comment.
This is WIP sorry I'm trying to make sure the integration test breaks properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.