Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: VetoableSlasher #377

Merged
merged 2 commits into from
Jan 31, 2025
Merged

refactor: VetoableSlasher #377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4b330a
refactor: remove unused '_slasher' constructor parameter
neutiyoo Jan 31, 2025
6ab76c8
refactor: use calldata instead of memory
neutiyoo Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/slashers/VetoableSlasher.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ contract VetoableSlasher is SlasherBase {

constructor(
IAllocationManager _allocationManager,
ISlashingRegistryCoordinator _slashingRegistryCoordinator,
address _slasher
ISlashingRegistryCoordinator _slashingRegistryCoordinator
) SlasherBase(_allocationManager, _slashingRegistryCoordinator) {}

function initialize(address _vetoCommittee, address _slasher) external virtual initializer {
Expand All @@ -30,7 +29,7 @@ contract VetoableSlasher is SlasherBase {
}

function queueSlashingRequest(
IAllocationManager.SlashingParams memory params
IAllocationManager.SlashingParams calldata params
) external virtual onlySlasher {
_queueSlashingRequest(params);
}
Expand Down Expand Up @@ -63,7 +62,7 @@ contract VetoableSlasher is SlasherBase {
}

function _queueSlashingRequest(
IAllocationManager.SlashingParams memory params
IAllocationManager.SlashingParams calldata params
) internal virtual {
uint256 requestId = nextRequestId++;
slashingRequests[requestId] = SlashingRequest({
Expand Down