Anvil testing updateOperatorsForQuorum #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally - renamed updateOperatorsPerQuorum to updateOperatorsForQuorum - sort by operator addresses instead of operatorIds
- sorted by ascending address instead of operatorId - sanitization checks on quorumNumbers, added quorumsAllExist modifier - performing `OperatorStatus.REGISTERED` checks now - Removed uneccesary bitmapToBytes calls and doing bytes slicing for quorumNumbers - using internal function and scoping to fix stack-too-deep
small off by 1 error, for example of quorumCount = 1,3 1 << 1 = 2, bit rep is 10 1 << 1 - 1 = 1, bit rep is 01 1 << 3 = 8, bit rep is 1000 1 << 3 - 1 = 7, bit rep is 0111 We should be subtracting by 1 instead of 2 here to get the bitmap
May change this in the future to be configurable
gpsanant
reviewed
Nov 16, 2023
| } | ||
| } | ||
|
|
||
| quorumUpdateTimestamp[quorumNumber] = block.timestamp; |
gpsanant
reviewed
Nov 16, 2023
| ); | ||
|
|
||
| { | ||
| uint192 currentBitmap = _currentOperatorBitmap(operatorId); |
There was a problem hiding this comment.
any way to reduce duplication between this and the other update stakes method?
There was a problem hiding this comment.
Let me try to create another PR for this
There was a problem hiding this comment.
#68
Take a look here
gpsanant
reviewed
Nov 16, 2023
src/BLSSignatureChecker.sol
Outdated
| @@ -73,6 +73,10 @@ contract BLSSignatureChecker is IBLSSignatureChecker { | |||
| // loop through every quorumNumber and keep track of the apk | |||
| BN254.G1Point memory apk = BN254.G1Point(0, 0); | |||
| for (uint i = 0; i < quorumNumbers.length; i++) { | |||
| require( | |||
| registryCoordinator.quorumUpdateTimestamp(uint8(quorumNumbers[i])) + 1 weeks <= block.timestamp, | |||
There was a problem hiding this comment.
should we set a minimum withdrawalDelayBlocks in delegation manager and set this to that?
There was a problem hiding this comment.
what if we just read the current DelegationManager.withdrawalDelayBlocks value instead?
There was a problem hiding this comment.
Added this in the feature PR e4f39f6 as well as the interface change to read off of the DM Layr-Labs/eigenlayer-contracts#344
8sunyuan
force-pushed
the
test/gas-testing-updates-per-quorum
branch
from
f836cf2 to
9d9c328
Compare
Additionally - renamed updateOperatorsPerQuorum to updateOperatorsForQuorum - sort by operator addresses instead of operatorIds
- sorted by ascending address instead of operatorId - sanitization checks on quorumNumbers, added quorumsAllExist modifier - performing `OperatorStatus.REGISTERED` checks now - Removed uneccesary bitmapToBytes calls and doing bytes slicing for quorumNumbers - using internal function and scoping to fix stack-too-deep
small off by 1 error, for example of quorumCount = 1,3 1 << 1 = 2, bit rep is 10 1 << 1 - 1 = 1, bit rep is 01 1 << 3 = 8, bit rep is 1000 1 << 3 - 1 = 7, bit rep is 0111 We should be subtracting by 1 instead of 2 here to get the bitmap
May change this in the future to be configurable
…-updates-per-quorum
Update all operators quorum0: ~13.9M gas Update all operators quorums1-9: ~8M gas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran tests with anvil node running the following commands
Assumptions:
Running updates for Quorum0 with 200 operators costs ~11.4M gas, updates for Quorums1-9 with 50 operators each costs ~6.4M gas. If using 30 operator cap instead of 50 then its ~4M.
Only mocked the
BLSPubkeyRegistrycontract in tests as generating BLS pubkeys for all 200 operators would have been much more of a chore. This affects gas estimations in the event that the operator stake is below the minimum requirement for the quorum and we have to rederegister them from all other registries.In this scenario, for Quorum0 and de-registering ALL 200 operators, it would cost approximately 2-3M more gas to perform the transaction. For updating all Quorums1-9 and all operators de-registering, it would cost approximately 3-5M more gas.
TL;DR In the worst case scenario where all operators deregister/have below minimum quorum stake, we can still update operators for Quorum0 and Quorums1-9 in two separate tx's.