Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--tolerance on find-stale-pods #144

Merged
merged 5 commits into from
Aug 29, 2024
Merged

--tolerance on find-stale-pods #144

merged 5 commits into from
Aug 29, 2024

Conversation

jbrower95
Copy link
Contributor

--tolerance 5 indicates that we should tolerate up to (but no more than) a 5% drop in the beacon balance before fixing the execution balance.

  • Previously we defaulted to a hardcoded 5 -- this allows folks to set their own version.

@jbrower95 jbrower95 marked this pull request as ready for review August 29, 2024 20:01
wadealexc
wadealexc approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@wadealexc wadealexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jbrower95 jbrower95 merged commit 216ab6c into master Aug 29, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpsanant gpsanant gpsanant approved these changes

@wadealexc wadealexc wadealexc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrower95 @wadealexc @gpsanant