Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isOperatorRegistered #102

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Fix isOperatorRegistered #102

merged 1 commit into from
Jan 21, 2024

Conversation

MaanavKhaitan
Copy link
Contributor

Motivation

  • isOperatorRegistered() was using the operator ID to determine if an operator is registered
  • This was an issue because after an operator de-registers from an AVS, their operator info and ID is not removed from the registry coordinator so isOperatorRegistered() was still returning true

Solution

  • Fixes isOperatorRegistered() so it uses operator status instead of operator ID to determine if an operator is registered

Testing

Tested this with the CLI in incredible-squaring-avs and verified that we're getting the correct value now for registeredWithAvs.

Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir, insta approve!
@shrimalmadhur the badge github action is still failing, prob because maanav is outside our org?

@samlaf samlaf merged commit 2db70d4 into Layr-Labs:master Jan 21, 2024
2 of 3 checks passed
@shrimalmadhur
Copy link
Collaborator

Thank you sir, insta approve! @shrimalmadhur the badge github action is still failing, prob because maanav is outside our org?

yea. I have made it optional so as long as unit test passes, we are good to merge. haven't found a good way to make it work with folks outside the org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants