Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[logger] Add With method for creating child logger #162

Merged
merged 1 commit into from
Mar 27, 2024
Merged

[logger] Add With method for creating child logger #162

merged 1 commit into from
Mar 27, 2024

Conversation

ian-shim
Copy link
Contributor

With method can be used to create child logger with default tags

samlaf
samlaf approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ian-shim ian-shim merged commit 5dec062 into master Mar 27, 2024
3 checks passed
@ian-shim ian-shim deleted the logger-add-with-method branch March 27, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

@dmanc dmanc Awaiting requested review from dmanc

@mooselumph mooselumph Awaiting requested review from mooselumph

@jianoaix jianoaix Awaiting requested review from jianoaix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @samlaf