[fireblocks] Adjust confirmation threshold #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
fireblocks-num-confirmations
branch
from
9dbb88d to
fc1db04
Compare
ian-shim
force-pushed
the
fireblocks-num-confirmations
branch
from
fc1db04 to
8fc5416
Compare
|
Seems like this PR sets a fixed confirmation threshold for the wallet and then updates the confirmation threshold for each individual transaction. I suppose there isn't a global fireblocks setting that can be used instead? |
There doesn't seem like an option to set the global threshold for the account 😢 |
mooselumph
reviewed
Apr 1, 2024
| @@ -199,6 +201,14 @@ func (t *fireblocksWallet) SendTransaction(ctx context.Context, tx *types.Transa | |||
| t.txIDToNonce[res.ID] = nonce | |||
| t.logger.Debug("Fireblocks contract call complete", "txID", res.ID, "status", res.Status) | |||
|
|
|||
| success, err := t.fireblocksClient.SetConfirmationThreshold(ctx, res.ID, t.confirmationThreshold) | |||
There was a problem hiding this comment.
Maybe use confirmationThreshold=0 or -1 to just use the default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting confirmation threshold for fireblocks transactions (which default to 3 otherwise)