Add read only builder #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
requested changes
Aug 14, 2024
|
I addressed all the comments and added some more docs. cc @samlaf |
samlaf
reviewed
Aug 15, 2024
| // Build an AVS registry client with the given configuration, | ||
| // HTTP and WS clients, and logger, but without a private key. | ||
| // | ||
| // This is useful for read-only operations, such as fetching metrics. |
There was a problem hiding this comment.
what does it mean by fetching metrics here?
There was a problem hiding this comment.
Yes, I think can be confusing. I'll remove that bit.
shrimalmadhur
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
This PR adds a new constructor for what used to be the Clients struct.
Now it is separated into 2 structs:
In this way there is a function for building only the reader part of the clients.