Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slashing #342

Merged
merged 5 commits into from
Jan 3, 2025
Merged

feat: slashing #342

merged 5 commits into from
Jan 3, 2025

Conversation

shrimalmadhur
Copy link
Collaborator

@shrimalmadhur shrimalmadhur commented Sep 18, 2024

[DO NOT MERGE]

Fixes # .

What Changed?

  • Slashing and Operator Set release

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@shrimalmadhur shrimalmadhur force-pushed the madhur/tmp-slashing branch 2 times, most recently from ae97f79 to f40967f Compare October 19, 2024 19:02
@shrimalmadhur shrimalmadhur force-pushed the madhur/tmp-slashing branch 3 times, most recently from 9547511 to e7e3855 Compare December 12, 2024 23:33
bdchatham
bdchatham previously approved these changes Dec 16, 2024
make improve

init

address comments

address comments

slashing push

working slashing

update contracts submodules

update to new AM

fix test

update to remove slasher and into AM

feat: add new funcs (#382)

Co-authored-by: Madhur Shrimal <[email protected]>

update contracts submodules

update contracts submodules

update with latest methods

rebase

update to ctx

change name

address comments

more methods

rebase and new changes

fix reader tests

fix reader tests

fmt

Updating core bindings and adding UserCanCall for UAM.

Adding PermissionController binding to binding constructors.

Adding list users and list permissions APIs to EL reader.

fix: anvil setup (#400)

Updating bindings and adding appointee remove & set implementations.

Fixing import ordering and returning tx receipt for appointee mutations.

Adding IsPendingAdmin & IsAdmin read APIs.

Adding admin mutation request types and APIs to writer implementation.

Updating based on make fmt results.

Updating user naming to appointee.

fmt

Adding factory methods to create unsigned transactions from the EL writer.

chore: update the core contract deps (#409)

add slashable shares (#410)

Parameterizing txOpts for injection for noOpt cases.

chore: remove staker_opt_out_window_blocks (#412)

Fixing lint errors for AddPendingAdmin on EL Writer.

Updating appointee set & remove methods to support injecting txOpts.
bdchatham
bdchatham previously approved these changes Jan 2, 2025
contracts/anvil/utils.sh Outdated Show resolved Hide resolved
@afkbyte
Copy link
Contributor

afkbyte commented Jan 3, 2025

want to also note that the nightly-3abac322efdb69e27b6fe8748b72754ae878f64d image we're pulling of anvil no longer exists - we should use the latest stable https://github.com/foundry-rs/foundry/pkgs/container/foundry/326174124?tag=stable (image should be "ghcr.io/foundry-rs/foundry:stable@sha256:daeeaaf4383ee0cbfc9f31f079a04ffb0123e49e5f67f2a20b5ce1ac1959a4d6")

@shrimalmadhur shrimalmadhur requested a review from afkbyte January 3, 2025 18:30
Copy link
Contributor

@afkbyte afkbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@shrimalmadhur shrimalmadhur added this pull request to the merge queue Jan 3, 2025
Merged via the queue into dev with commit fce9e63 Jan 3, 2025
6 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/tmp-slashing branch January 3, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants