Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid panics #389

Merged
merged 19 commits into from
Jan 17, 2025
Merged

Avoid panics #389

merged 19 commits into from
Jan 17, 2025

Conversation

pablodeymo
Copy link
Contributor

@pablodeymo pablodeymo commented Nov 1, 2024 •
edited by MegaRedHand
Loading

Fixes # .

What Changed?

The functions BuildReadClients, BuildAll, NewZapLoggerByConfig, and AvsRegistryServiceChainCaller.GetOperatorsAvsStateAtBlock return errors instead of panicking.
The OperatorsInfoServiceInMemory no longer panics (errors are only logged).

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@pablodeymo pablodeymo changed the title Change Errors fatal to return the error instead Avoid panics Nov 5, 2024
@pablodeymo pablodeymo marked this pull request as ready for review November 5, 2024 19:38
@pablodeymo pablodeymo added the v0.2 new dev version label Nov 12, 2024
@MegaRedHand MegaRedHand added this pull request to the merge queue Jan 17, 2025
Merged via the queue into dev with commit 583fc32 Jan 17, 2025
6 checks passed
@MegaRedHand MegaRedHand deleted the errors_fatal branch January 17, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand left review comments

@afkbyte afkbyte afkbyte approved these changes

Assignees
No one assigned
Labels
v0.2 new dev version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablodeymo @MegaRedHand @afkbyte