fix: anvil setup #400
Merged
fix: anvil setup #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdchatham
approved these changes
Dec 6, 2024
| IAVSDirectory avsDirectory; | ||
| IRewardsCoordinator rewardsCoordinator; | ||
| StrategyBaseTVLLimits baseStrategyImplementation; | ||
| IAllocationManager allocationManager; |
There was a problem hiding this comment.
nit: should we add permission controller as well?
There was a problem hiding this comment.
I want to first fix it for existing test. but yes we can add that.
shrimalmadhur
force-pushed
the
madhur/fix-anvil-setup
branch
4 times, most recently
from
396f256 to
cfe951f
Compare
resolve some issues anvil save state complete fmt updated contracts fix address and a bug fmt
shrimalmadhur
force-pushed
the
madhur/fix-anvil-setup
branch
from
7e4ef4a to
e2bb5a9
Compare
shrimalmadhur
added a commit
that referenced
this pull request
Dec 12, 2024
make improve init address comments address comments slashing push working slashing update contracts submodules update to new AM fix test update to remove slasher and into AM feat: add new funcs (#382) Co-authored-by: Madhur Shrimal <[email protected]> update contracts submodules update contracts submodules update with latest methods rebase update to ctx change name address comments more methods rebase and new changes fix reader tests fix reader tests fmt Updating core bindings and adding UserCanCall for UAM. Adding PermissionController binding to binding constructors. Adding list users and list permissions APIs to EL reader. fix: anvil setup (#400) Updating bindings and adding appointee remove & set implementations. Fixing import ordering and returning tx receipt for appointee mutations. Adding IsPendingAdmin & IsAdmin read APIs. Adding admin mutation request types and APIs to writer implementation. Updating based on make fmt results. Updating user naming to appointee.
shrimalmadhur
added a commit
that referenced
this pull request
Dec 12, 2024
make improve init address comments address comments slashing push working slashing update contracts submodules update to new AM fix test update to remove slasher and into AM feat: add new funcs (#382) Co-authored-by: Madhur Shrimal <[email protected]> update contracts submodules update contracts submodules update with latest methods rebase update to ctx change name address comments more methods rebase and new changes fix reader tests fix reader tests fmt Updating core bindings and adding UserCanCall for UAM. Adding PermissionController binding to binding constructors. Adding list users and list permissions APIs to EL reader. fix: anvil setup (#400) Updating bindings and adding appointee remove & set implementations. Fixing import ordering and returning tx receipt for appointee mutations. Adding IsPendingAdmin & IsAdmin read APIs. Adding admin mutation request types and APIs to writer implementation. Updating based on make fmt results. Updating user naming to appointee.
shrimalmadhur
added a commit
that referenced
this pull request
Dec 12, 2024
make improve init address comments address comments slashing push working slashing update contracts submodules update to new AM fix test update to remove slasher and into AM feat: add new funcs (#382) Co-authored-by: Madhur Shrimal <[email protected]> update contracts submodules update contracts submodules update with latest methods rebase update to ctx change name address comments more methods rebase and new changes fix reader tests fix reader tests fmt Updating core bindings and adding UserCanCall for UAM. Adding PermissionController binding to binding constructors. Adding list users and list permissions APIs to EL reader. fix: anvil setup (#400) Updating bindings and adding appointee remove & set implementations. Fixing import ordering and returning tx receipt for appointee mutations. Adding IsPendingAdmin & IsAdmin read APIs. Adding admin mutation request types and APIs to writer implementation. Updating based on make fmt results. Updating user naming to appointee.
shrimalmadhur
added a commit
that referenced
this pull request
Jan 2, 2025
make improve init address comments address comments slashing push working slashing update contracts submodules update to new AM fix test update to remove slasher and into AM feat: add new funcs (#382) Co-authored-by: Madhur Shrimal <[email protected]> update contracts submodules update contracts submodules update with latest methods rebase update to ctx change name address comments more methods rebase and new changes fix reader tests fix reader tests fmt Updating core bindings and adding UserCanCall for UAM. Adding PermissionController binding to binding constructors. Adding list users and list permissions APIs to EL reader. fix: anvil setup (#400) Updating bindings and adding appointee remove & set implementations. Fixing import ordering and returning tx receipt for appointee mutations. Adding IsPendingAdmin & IsAdmin read APIs. Adding admin mutation request types and APIs to writer implementation. Updating based on make fmt results. Updating user naming to appointee. fmt Adding factory methods to create unsigned transactions from the EL writer. chore: update the core contract deps (#409) add slashable shares (#410) Parameterizing txOpts for injection for noOpt cases. chore: remove staker_opt_out_window_blocks (#412) Fixing lint errors for AddPendingAdmin on EL Writer. Updating appointee set & remove methods to support injecting txOpts.
shrimalmadhur
added a commit
that referenced
this pull request
Jan 2, 2025
make improve init address comments address comments slashing push working slashing update contracts submodules update to new AM fix test update to remove slasher and into AM feat: add new funcs (#382) Co-authored-by: Madhur Shrimal <[email protected]> update contracts submodules update contracts submodules update with latest methods rebase update to ctx change name address comments more methods rebase and new changes fix reader tests fix reader tests fmt Updating core bindings and adding UserCanCall for UAM. Adding PermissionController binding to binding constructors. Adding list users and list permissions APIs to EL reader. fix: anvil setup (#400) Updating bindings and adding appointee remove & set implementations. Fixing import ordering and returning tx receipt for appointee mutations. Adding IsPendingAdmin & IsAdmin read APIs. Adding admin mutation request types and APIs to writer implementation. Updating based on make fmt results. Updating user naming to appointee. fmt Adding factory methods to create unsigned transactions from the EL writer. chore: update the core contract deps (#409) add slashable shares (#410) Parameterizing txOpts for injection for noOpt cases. chore: remove staker_opt_out_window_blocks (#412) Fixing lint errors for AddPendingAdmin on EL Writer. Updating appointee set & remove methods to support injecting txOpts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix anvil setup