Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance test for BLS signature #402

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Conversation

pablodeymo
Copy link
Contributor

Fixes # .

What Changed?

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

afkbyte
afkbyte previously approved these changes Jan 15, 2025
x := sig.G1Affine.X.String()
y := sig.G1Affine.Y.String()

assert.Equal(t, x, "15790168376429033610067099039091292283117017641532256477437243974517959682102")
Copy link
Contributor

@afkbyte afkbyte Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would add a comment on where these values are from

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@afkbyte afkbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send_new_signedTaskDigest_before_listen_on_responseChan_-_context_timeout_cancels_the_request_to_prevent_deadlock is failing in the CI but unrelated to this test. LGTM.

@MegaRedHand MegaRedHand added this pull request to the merge queue Jan 17, 2025
Merged via the queue into dev with commit 1eff90f Jan 17, 2025
6 checks passed
@MegaRedHand MegaRedHand deleted the bls_signature_compliance_test branch January 17, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants