-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compliance test for BLS signature #402
Conversation
x := sig.G1Affine.X.String() | ||
y := sig.G1Affine.Y.String() | ||
|
||
assert.Equal(t, x, "15790168376429033610067099039091292283117017641532256477437243974517959682102") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I would add a comment on where these values are from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
send_new_signedTaskDigest_before_listen_on_responseChan_-_context_timeout_cancels_the_request_to_prevent_deadlock
is failing in the CI but unrelated to this test. LGTM.
Fixes # .
What Changed?
Reviewer Checklist