Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tx mgr for onchain transactions #75

Merged
merged 3 commits into from
Dec 9, 2023
Merged

tx mgr for onchain transactions #75

merged 3 commits into from
Dec 9, 2023

Conversation

shrimalmadhur
Copy link
Collaborator

@shrimalmadhur shrimalmadhur commented Nov 7, 2023 •
edited
Loading

Fixes #25 .

Motivation

Solution

I have just implemented it for RegisterAsOperator so that we can review

Open questions

samlaf
samlaf reviewed Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like good starting point. Added first set of comments. This is pretty complicated stuff. Not sure what is happening in a bunch of places, or why this complexity is needed, so added a bunch of questions.

signerv2/signer.go Outdated Show resolved Hide resolved
crypto/ecdsa/utils.go Show resolved Hide resolved
crypto/ecdsa/utils.go Show resolved Hide resolved
chainio/txmgr/txmgr.go Outdated Show resolved Hide resolved
chainio/txmgr/txmgr.go Outdated Show resolved Hide resolved
chainio/txmgr/txmgr.go Outdated Show resolved Hide resolved
signerv2/signer.go Outdated Show resolved Hide resolved
signerv2/signer.go Show resolved Hide resolved
chainio/txmgr/txmgr.go Show resolved Hide resolved
chainio/txmgr/txmgr.go Show resolved Hide resolved
@shrimalmadhur shrimalmadhur marked this pull request as ready for review November 8, 2023 19:19
@shrimalmadhur shrimalmadhur changed the title [WIP] tx mgr tx mgr for onchain transactions Nov 8, 2023
@shrimalmadhur shrimalmadhur mentioned this pull request Nov 29, 2023
Merged
@shrimalmadhur shrimalmadhur requested a review from samlaf December 1, 2023 00:25
@shrimalmadhur
tx mgr
d78cff8 
working tx mgr

add from

fix err

simplify signer and address comments

added flow diagram and comments

remove unused call
@shrimalmadhur
fmt
f4ca08e
@shrimalmadhur shrimalmadhur requested a review from samlaf December 9, 2023 01:09
@samlaf samlaf merged commit 59487c7 into master Dec 9, 2023
3 checks passed
@samlaf samlaf deleted the madhur/tx-mgr branch December 9, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Transaction Manager for onchain interactions
2 participants
@shrimalmadhur @samlaf