ci: fix check bindings job #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
previously requested changes
Jan 23, 2025
ricomateo
force-pushed
the
solc-pinned
branch
from
55cd7db to
cc4579f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
The
Check bindingsCI job was failing due to mismatches in the bindings generated by the CI and the ones generated by the Docker container.This PR introduces the following changes:
latest(24.04) to 22.04. With this change, the bindings generated by the CI are the same as the Docker container ones.git diff --exit-codeinstead of copying the existing bindings and runningdiff.Reviewer Checklist
changelog-Xlabels (if applies)