Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix job that checks anvil state is up-to-date #255

Closed
wants to merge 42 commits into from

Conversation

ricomateo
Copy link
Contributor

@ricomateo ricomateo commented Jan 30, 2025

Motivation

The previous CI job that checked whether the anvil state was up to date was actually not performing any comparison at all (it was mistakenly comparing empty files).

Checking that the anvil state is up to date by re-generating it and comparing it with the existing one was not very practical since this approach is very time-sensitive: any difference in the timestamps generates a different state, which the CI wrongly takes as an outdated state.

What Changed?

This PR introduces the following changes in the CI:

Removes the step that compares the anvil state in the tests CI job, and simply checks that the script to generate the state works.
Adds a new job that checks whether the anvil state is updated (it runs only when the contracts change).

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@ricomateo ricomateo added the changelog-ignore PR is allowed to skip the changelog label Jan 30, 2025
@ricomateo ricomateo closed this Jan 30, 2025
@MegaRedHand MegaRedHand deleted the fix-anvil-ci-job branch February 6, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-ignore PR is allowed to skip the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants