Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bls_aggr encapsulate parameters into TaskSignature #260

Merged
merged 14 commits into from
Feb 6, 2025

Conversation

damiramirez
Copy link

@damiramirez damiramirez commented Jan 30, 2025

What Changed?

This PR refactors the process_new_signature function by encapsulating related parameters into a new struct called TaskSignature.

  • Create TaskSignature struct with a constructor method.
  • process_new_signature now accepts a TaskSignature instead of separate parameters.
  • Update CHANGELOG.md
pub struct TaskSignature {
    task_index: TaskIndex,
    task_response_digest: TaskResponseDigest,
    bls_signature: Signature,
    operator_id: FixedBytes<32>,
}

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@damiramirez damiramirez changed the title refactor: encapsulate parameters into TaskSignature refactor: bls_aggr encapsulate parameters into TaskSignature Jan 30, 2025
@damiramirez damiramirez marked this pull request as ready for review January 30, 2025 20:09
@damiramirez damiramirez changed the base branch from main to dev February 3, 2025 17:35
@MegaRedHand
Copy link
Contributor

Please sync with dev and update the changelog

Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablodeymo pablodeymo merged commit fe9fefe into Layr-Labs:dev Feb 6, 2025
9 of 11 checks passed
@pablodeymo pablodeymo deleted the refactor/signature-process branch February 6, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants