-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: bls_aggr
encapsulate parameters into TaskSignature
#260
Merged
pablodeymo
merged 14 commits into
Layr-Labs:dev
from
lambdaclass:refactor/signature-process
Feb 6, 2025
Merged
refactor: bls_aggr
encapsulate parameters into TaskSignature
#260
pablodeymo
merged 14 commits into
Layr-Labs:dev
from
lambdaclass:refactor/signature-process
Feb 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaskSignature
bls_aggr
encapsulate parameters into TaskSignature
Please sync with dev and update the changelog |
MegaRedHand
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pablodeymo
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
This PR refactors the
process_new_signature
function by encapsulating related parameters into a new struct calledTaskSignature
.TaskSignature
struct with a constructor method.process_new_signature
now accepts aTaskSignature
instead of separate parameters.CHANGELOG.md
Reviewer Checklist
changelog-X
labels (if applies)