Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ABIs, Reducing New Task Time #135

Closed
wants to merge 1 commit into from
Closed

Conversation

wesfloyd
Copy link
Contributor

@wesfloyd wesfloyd commented Mar 6, 2025

gm @stevennevins - how do you feel about these 2x small changes & updates?

@wesfloyd wesfloyd requested a review from stevennevins March 6, 2025 13:36
Copy link
Contributor

@MegaRedHand MegaRedHand Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently updated contracts to v1.1.1 of middleware and regenerated the abi files (#130). Some of these changes aren't there though. Could you let me know how you generated these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a helpful callout. I simply ran build, extract ABIs, etc per our instructions here.

I think git fetch (updates) did not automatically update the submodules! Which likely resulted in my ABIs not looking right.

Do you have any best practice for updating those submodules when you update your repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh sorry, old habits die hard. I'm still used to asking smart humans like you for help, when I should be asking the superintelligence to save our time 🤣

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git submodule update --init --recursive

if you see a diff in your lib/{some-dependency} in a foundry project then you usually need to run the above

Copy link
Contributor

@MegaRedHand MegaRedHand Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or the good old rm -rf lib/{some-dependency} && git submodule update --init --recursive when the above doesn't help.
I'm still looking for a way to make git update submodules automatically when switching branches 😞

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe soldeer would help here?

@wesfloyd
Copy link
Contributor Author

wesfloyd commented Mar 7, 2025

Updating the submodules fixed it! Thanks all, will close this PR - no longer needed

@wesfloyd wesfloyd closed this Mar 7, 2025
@MegaRedHand MegaRedHand deleted the wf-abis-task-time branch March 7, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants