Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment passing arbitrator JIT test test_crate #24

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

hopeyen
Copy link

@hopeyen hopeyen commented Aug 8, 2024

Resolve #9
Per comment #9 (comment), this PR simply uncomment the test as the previous failure might've been a regression solved when codebase rebased to v3.0.3

@hopeyen hopeyen added the good first issue Good for newcomers label Aug 8, 2024
@hopeyen hopeyen requested a review from epociask August 8, 2024 11:58
@hopeyen hopeyen self-assigned this Aug 8, 2024
Copy link
Collaborator

@epociask epociask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hopeyen hopeyen force-pushed the hope/uncomment-test-crate branch from 47cd9cd to 713c6d5 Compare August 12, 2024 18:43
@epociask epociask merged commit e655c8d into eigenda-v3.0.3 Aug 13, 2024
8 checks passed
@hopeyen hopeyen deleted the hope/uncomment-test-crate branch August 26, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants