Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add config processing invariant which enforces that 4844 must be disabled w/ eigenda unless failover is set #51

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: Add config processing invariant which enforces that 4844 must be disabled w/ eigenda unless failover is set #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32a9add
fix: Add config processing invariant which enforces that 4844 must be…
epociask Dec 4, 2024
33df6dd
fix: Add config processing invariant which enforces that 4844 must be…
epociask Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/nitro/nitro.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,6 +592,11 @@ func mainImpl() int {
log.Error("batchPoster's MaxEigenDABatchSize too large.", "MaxEigenDABatchSize", eigenda.MaxBatchSize)
return 1
}

if !nodeConfig.Node.BatchPoster.EnableEigenDAFailover && nodeConfig.Node.Dangerous.DisableBlobReader {
log.Error("4844 must be disabled if using EigenDA without failover enabled")
return 1
}
}
// If sequencer is enabled, validate MaxTxDataSize to be at least 5kB below the batch poster's MaxSize to allow space for headers and such.
// And since batchposter's MaxSize is to be at least 10kB below the sequencer inbox’s maxDataSize, this leads to another condition of atlest 15kB below the sequencer inbox’s maxDataSize.
Expand Down
Loading