Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation EntityShape #571

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implementation EntityShape #571

wants to merge 1 commit into from

Conversation

LeMyst
Copy link
Owner

@LeMyst LeMyst commented Jun 23, 2023

Fix #470

@LeMyst
Copy link
Owner Author

LeMyst commented Jun 23, 2023

Github Actions fails because entityshape is not available for Python 3.7. The problem will be solved next week with the depreciation of 3.7 in WBI.

@LeMyst LeMyst force-pushed the add-entityshape branch 2 times, most recently from 43f0bef to 5e76716 Compare June 24, 2023 07:56
@LeMyst LeMyst marked this pull request as ready for review June 24, 2023 10:47
@LeMyst
Copy link
Owner Author

LeMyst commented Jun 24, 2023

@dpriskorn What's your opinion?

dpriskorn
dpriskorn reviewed Jun 25, 2023
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
dpriskorn
dpriskorn reviewed Jun 25, 2023
View reviewed changes
Copy link
Contributor

@dpriskorn dpriskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work :)
See my inline comments for suggestions.

dpriskorn
dpriskorn reviewed Jun 25, 2023
View reviewed changes
test/test_entity_item.py Outdated Show resolved Hide resolved
@dpriskorn
Copy link
Contributor

Also, please note than the support for shex is very basic in entityshape right now. See dpriskorn/entityshape#7

@dpriskorn
Copy link
Contributor

Note: new version with breaking change https://github.com/dpriskorn/entityshape/releases/tag/0.1.0

@dpriskorn
Copy link
Contributor

LGTM

@LeMyst LeMyst force-pushed the add-entityshape branch 2 times, most recently from c6e23b5 to aa81f3b Compare January 7, 2024 14:21
@LeMyst
Copy link
Owner Author

LeMyst commented Jan 7, 2024

@dpriskorn
Wait for dpriskorn/entityshape#22 to fully test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpriskorn dpriskorn dpriskorn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: entityschemas and validation.
2 participants
@LeMyst @dpriskorn