V2Application Compatability Changes #130
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya! I haven't really used this module before, but a user of the module I'm currently making was interested in using it. So I noticed that the Popout module isn't handling foundry's V2 Applications.
I made some changes that allows my V2 application to render perfectly. And it doesn't seem to have any impact on V1 applications, since all I'm really doing is wrapping a JQuery context around some calls so that both the V1 and V2 apps can compute properly.
The only other thing I added was attaching a 'Popout' class to the main element. This is just something I think would be very usefull as it would allow modules to change their styling based on that class being present (something I needed).
Could very well be some important stuff I'm not considering since I'm not deeply familiar with the code, but give it a think 😁