Fix cookie parsing problem and location redirection with '//' at the beginning of location header #87

yyfrankyy · 2012-09-18T15:43:26Z

fix #85 and #86

tj · 2012-09-18T16:06:58Z

lib/browser.js

@@ -232,6 +232,10 @@ Browser.prototype.request = function(method, path, options, fn, saveHistory){

    // Redirect
    if (status >= 300 && status < 400) {
+      if (0 == res.headers.location.indexOf('//')) {
+        var isHttps = req.connection.server instanceof require('tls').Server || (req.headers && req.headers['x-forwarded-proto'] == 'https')


this line is mega-long, this should be fine this.connection.encrypted || forwardedstuffhere, break it into two vars so it's not so crazy.
var fwd = req.headers && req.... this.connection.encrypted || fwd == 'https'

Thanks for mention that, I committed a fix here.

fix #85 and fix #86

3827864

tj reviewed Sep 18, 2012
View reviewed changes

yyfrankyy added 2 commits September 19, 2012 00:47

prevent cookie w/o Path=/ cause exception and fix #88

8449e28

use this.connection.encrypted for detecting https connection

d8ba955

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix cookie parsing problem and location redirection with '//' at the beginning of location header #87

Fix cookie parsing problem and location redirection with '//' at the beginning of location header #87

yyfrankyy commented Sep 18, 2012

tj Sep 18, 2012

yyfrankyy Sep 18, 2012

Fix cookie parsing problem and location redirection with '//' at the beginning of location header #87

Are you sure you want to change the base?

Fix cookie parsing problem and location redirection with '//' at the beginning of location header #87

Conversation

yyfrankyy commented Sep 18, 2012

tj Sep 18, 2012

Choose a reason for hiding this comment

yyfrankyy Sep 18, 2012

Choose a reason for hiding this comment